Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(payment-methods): Fix provider payment methods #1795

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

ivannovosad
Copy link
Contributor

Context

Stripe payment methods were automatically overridden by Lago.

Steps to reproduce:

Create a customer via API with stripe as the payment provider and "provider_payment_methods": ["card","sepa_debit"];

Update the customer account via API by sending only external_id and a random field, such as city (do not send anything related to billing_configuration);

In the API response, you can see that Lago automatically removed "sepa_debit" from the list of available payment methods.

Expected behaviour: when updating a customer, only the attributes included in the request payload should be modified.

Description

This PR fixes updating provider customer specifically the payment methods when no payment method is sent.

Copy link
Collaborator

@vincent-pochet vincent-pochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ivannovosad ivannovosad merged commit 097e6a2 into main Mar 18, 2024
7 checks passed
@ivannovosad ivannovosad deleted the fix-payment-methods branch March 18, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants