fix(invoices): Fix boundaries when in advance anniversary #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
force-pushed
the
fix-boundaries
branch
from
8a4c65d
to
9bf6839
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
An issue have been identified when a subscription is billed in advance on a monthly basis if the subscription starts on a 30 and the billing month is shorter than the subscription month
Subscription_at = 30th of January, billed on an anniversary basis
Plan: Monthly, billed in advance
On the billing day of February 29th, the following boundaries were returned:
The expected boundaries are:
Description
This PR ensure that the boundaries are correct