fix(pdf): Remove extra blank link in custom footer #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
approved these changes
Apr 8, 2024
julienbourdeau
force-pushed
the
fix/blank-line-footer
branch
from
ac85555
to
2ae9c8d
Compare
julienbourdeau
force-pushed
the
fix/blank-line-footer
branch
from
2ae9c8d
to
430485d
Compare
drejc
pushed a commit
to fliqa-io/lago-api
that referenced
this pull request
May 15, 2024
## Context An organisation can choose to display a custom text block on invoices. ## Description With this change, we'll ensure the all the blank line before and after the last lines are removed. We'll also remove extra blank lines. ### Example #### CONFIG <img width="1021" alt="Screenshot 2024-04-08 at 14 05 30" src="https://github.com/getlago/lago-api/assets/1525636/e44acb32-fede-404b-9f69-5fe7e6704a2f"> #### BEFORE <img width="851" alt="Screenshot 2024-04-08 at 13 58 00" src="https://github.com/getlago/lago-api/assets/1525636/890b58b4-735b-442b-b843-7efee1a6dff2"> #### AFTER <img width="855" alt="Screenshot 2024-04-08 at 13 58 57" src="https://github.com/getlago/lago-api/assets/1525636/a19971ee-1013-42fc-9419-e1f1971bf188">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
An organisation can choose to display a custom text block on invoices.
Description
With this change, we'll ensure the all the blank line before and after the last lines are removed. We'll also remove extra blank lines.
Example
CONFIG
BEFORE
AFTER