Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): Move Sidekiq config to initializer #1861

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

julienbourdeau
Copy link
Contributor

@julienbourdeau julienbourdeau commented Apr 11, 2024

Description

Very small improvements:

  • Move sidekiq session config to initializer rather than routes.rb.
  • Only require 'sidekiq/web' if we're going to mount it

See #1071

@julienbourdeau julienbourdeau marked this pull request as draft April 11, 2024 07:45
@julienbourdeau julienbourdeau self-assigned this Apr 11, 2024
@julienbourdeau julienbourdeau marked this pull request as ready for review April 11, 2024 07:59
@ivannovosad ivannovosad self-requested a review April 11, 2024 08:16
Copy link
Collaborator

@vincent-pochet vincent-pochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@julienbourdeau julienbourdeau merged commit 67abfdb into main Apr 11, 2024
6 checks passed
@julienbourdeau julienbourdeau deleted the chore/move-sidekiq-config branch April 11, 2024 08:30
drejc pushed a commit to fliqa-io/lago-api that referenced this pull request May 15, 2024
## Description

Very small improvements:

* Move sidekiq session config to initializer rather than `routes.rb`.
* Only `require 'sidekiq/web'` if we're going to mount it

See getlago#1071
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants