Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Better date definition for flacky test #1874

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

julienbourdeau
Copy link
Contributor

Test was failing on main.

Failures:

  1) Subscriptions::FreeTrialBillingService#call with trial ended due to previous subscription with the same external_id sets trial_ended_at
     Failure/Error: expect { service.call }.to change { sub.reload.trial_ended_at }.from(nil).to(sub.trial_end_datetime)
       expected `sub.reload.trial_ended_at` to have changed from nil to 2024-04-16 07:21:40.129012000 +0000, but did not change
     # ./spec/services/subscriptions/free_trial_billing_service_spec.rb:38:in `block (4 levels) in <top (required)>'
     # ./spec/spec_helper.rb:31:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:30:in `block (2 levels) in <top (required)>'

Finished in 5 minutes 2 seconds (files took 9.89 seconds to load)
4546 examples, 1 failure

@julienbourdeau julienbourdeau self-assigned this Apr 16, 2024
@julienbourdeau julienbourdeau merged commit c8a2835 into main Apr 16, 2024
6 checks passed
@julienbourdeau julienbourdeau deleted the fix/flaky-trial-test branch April 16, 2024 08:43
drejc pushed a commit to fliqa-io/lago-api that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants