feat(custom_agg): Whitelist custom_properties in charge properties #1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
force-pushed
the
feat-custom-agg-graphql
branch
from
5e64342
to
2ea046f
Compare
lovrocolic
approved these changes
Apr 16, 2024
vincent-pochet
force-pushed
the
feat-custom-agg-graphql
branch
from
2ea046f
to
35ea619
Compare
drejc
pushed a commit
to fliqa-io/lago-api
that referenced
this pull request
May 15, 2024
…etlago#1877) ## Context Some of our customers have express a need for aggregation and charge models that does not fit into the current logic in place in Lago, like for example having a single aggregation for 2 different properties, but make the price per unit changing based on the position of the event. This feature aims to propose a way to build custom aggregation logic for specific cases. ## Description This PR adds the whitelisting logic for `custom_properties` in the `charge#properties` object and updates the GraphQL type to expose this field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Some of our customers have express a need for aggregation and charge models that does not fit into the current logic in place in Lago, like for example having a single aggregation for 2 different properties, but make the price per unit changing based on the position of the event.
This feature aims to propose a way to build custom aggregation logic for specific cases.
Description
This PR adds the whitelisting logic for
custom_propertiesin thecharge#propertiesobject and updates the GraphQL type to expose this field