fix(invoice): Remove charges if charge boundaries are invalid #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienbourdeau
force-pushed
the
fix/invalid-charge-boundaries
branch
from
dc034ae
to
2d5053b
Compare
rsempe
reviewed
Apr 17, 2024
rsempe
approved these changes
Apr 17, 2024
julienbourdeau
force-pushed
the
fix/invalid-charge-boundaries
branch
from
2d5053b
to
1cc08cf
Compare
drejc
pushed a commit
to fliqa-io/lago-api
that referenced
this pull request
May 15, 2024
…o#1883) https://linear.app/getlago/issue/DLVRY-262 ## Context Subscriptions fees are now invoiced at the end of the trial instead of at the beginning of the subscription. We made a change were we don't always skip charge fees if it's the first invoice anymore. See getlago#1836 ## Description In some cases, the system might create invalid charge boundaries. This is not new but those cases always happened on the first invoice, and previously, we were skipping charges in this case so it was never visible. With this PR, we'll ensure a charge is only created if the boundaries are valid. Next, we'll need to look into *why* the boundaries are invalid in the first place but it's important to merge this fix in the meantime. ### Example of invalid boundaries on upgrade 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/getlago/issue/DLVRY-262
Context
Subscriptions fees are now invoiced at the end of the trial instead of at the beginning of the subscription. We made a change were we don't always skip charge fees if it's the first invoice anymore. See #1836
Description
In some cases, the system might create invalid charge boundaries. This is not new but those cases always happened on the first invoice, and previously, we were skipping charges in this case so it was never visible.
With this PR, we'll ensure a charge is only created if the boundaries are valid. Next, we'll need to look into why the boundaries are invalid in the first place but it's important to merge this fix in the meantime.
Example of invalid boundaries on upgrade