fix(trial): Ignore subscription if there is no free trial set #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsempe
approved these changes
Apr 22, 2024
drejc
pushed a commit
to fliqa-io/lago-api
that referenced
this pull request
May 15, 2024
…o#1906) ## Description When a plan free trial has ended, we invoice the subscription, set `subscription.trial_ended_at` attribute and send the `subscription.trial_ended` webhook. This fix will ensure we do this work *only* if the plan attached to the subscriptions has a free trial configured. Note that in ruby, the `subscription.trial_ended_datetime` method already returns nil if there is no trial_period configured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a plan free trial has ended, we invoice the subscription, set
subscription.trial_ended_atattribute and send thesubscription.trial_endedwebhook.This fix will ensure we do this work only if the plan attached to the subscriptions has a free trial configured.
Note that in ruby, the
subscription.trial_ended_datetimemethod already returns nil if there is no trial_period configured.