Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filter): Fix email template with fee display name #1910

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

vincent-pochet
Copy link
Collaborator

Description

This PR is a fix for the following error in InvoiceMailer:

undefined method `charge?' for #<Invoice id: "<GUID>", created_at: "<DATETIME>", updated_at: "<DATETIME>", issuing_date: "<DATE>", taxes_amount_cents: 0, total_amount_cents: 0, invoice_type: "subscription", payment_status: "succeeded", number: "SOR-D491-348-140", sequential_id: 140, file: nil, customer_id: "<GUID>", taxes_rate: 0.0, status: "finalized", timezone: "UTC", payment_attempts: 0, ready_for_payment_processing: true, organization_id: "<GUID>", version_number: 4, currency: "USD", fees_amount_cents: 0, coupons_amount_cents: 0, credit_notes_amount_cents: 0, prepaid_credit_amount_cents: 0, sub_total_excluding_taxes_amount_cents: 0, sub_total_including_taxes_amount_cents: 0, payment_due_date: "<DATE>", net_payment_term: 0, voided_at: nil, organization_sequential_id: 0, ready_to_be_refreshed: false, payment_dispute_lost_at: nil, skip_charges: false>

@vincent-pochet vincent-pochet self-assigned this Apr 22, 2024
@vincent-pochet vincent-pochet merged commit 742c4e9 into main Apr 23, 2024
6 checks passed
@vincent-pochet vincent-pochet deleted the feat-filters branch April 23, 2024 07:09
drejc pushed a commit to fliqa-io/lago-api that referenced this pull request May 15, 2024
## Description

This PR is a fix for the following error in InvoiceMailer:

```
undefined method `charge?' for #<Invoice id: "<GUID>", created_at: "<DATETIME>", updated_at: "<DATETIME>", issuing_date: "<DATE>", taxes_amount_cents: 0, total_amount_cents: 0, invoice_type: "subscription", payment_status: "succeeded", number: "SOR-D491-348-140", sequential_id: 140, file: nil, customer_id: "<GUID>", taxes_rate: 0.0, status: "finalized", timezone: "UTC", payment_attempts: 0, ready_for_payment_processing: true, organization_id: "<GUID>", version_number: 4, currency: "USD", fees_amount_cents: 0, coupons_amount_cents: 0, credit_notes_amount_cents: 0, prepaid_credit_amount_cents: 0, sub_total_excluding_taxes_amount_cents: 0, sub_total_including_taxes_amount_cents: 0, payment_due_date: "<DATE>", net_payment_term: 0, voided_at: nil, organization_sequential_id: 0, ready_to_be_refreshed: false, payment_dispute_lost_at: nil, skip_charges: false>
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants