Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: add missing KWD currency #1413

Merged
merged 1 commit into from
Feb 12, 2024
Merged

misc: add missing KWD currency #1413

merged 1 commit into from
Feb 12, 2024

Conversation

lovrocolic
Copy link
Collaborator

Context

This PR adds missing KWD currency

ansmonjol
ansmonjol requested changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@ansmonjol ansmonjol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This currency can have up to 3 decimal precision

You should add it to the list of 3 precision currencies in src/core/serializers/serializeAmount.ts

@michaelponrajah
Copy link

michaelponrajah commented Feb 9, 2024 •
edited

I think KWD is already mentioned here, line 4

@lovrocolic
Copy link
Collaborator Author

lovrocolic commented Feb 12, 2024 •
edited

I think KWD is already mentioned here, line 4

yep, KWD has been included in the list from the start

@lovrocolic lovrocolic merged commit b1d9d7d into main Feb 12, 2024
20 checks passed
@lovrocolic lovrocolic deleted the update-kwd-definition branch February 12, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansmonjol ansmonjol ansmonjol requested changes

@vincent-pochet vincent-pochet vincent-pochet approved these changes

@jdenquin jdenquin jdenquin approved these changes

@michaelponrajah michaelponrajah michaelponrajah approved these changes

@rsempe rsempe Awaiting requested review from rsempe

@ivannovosad ivannovosad Awaiting requested review from ivannovosad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lovrocolic @michaelponrajah @vincent-pochet @jdenquin @ansmonjol