bug(plan) make sure groupBy is undefined if not defined #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
approved these changes
Feb 20, 2024
rsempe
approved these changes
Feb 20, 2024
ansmonjol
force-pushed
the
reset-group-by
branch
from
c80ec68
to
6f76699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We perform some manual operations on this field
We receive it as an array of string, but we manipulate it as a string in the UI.
This value has to be re-transformed before sending it to the BE
Description
All those manipulations makes is less predictable and lead to have the value empty for the charge models that are not standard.
This PR ensure the value is undefined in such case.