Integrating smaller lantern-ui into flashlight-build #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2dada07 git-subtree-dir: src/github.com/getlantern/lantern-ui git-subtree-split: 2dada071031e58daa07c91f3ed428a1ffe4fa63a
…b.com/getlantern/lantern-ui'
| @@ -55,6 +59,11 @@ The script `tagandbuild.bash` tags and runs crosscompile.bash. | |||
|
|
|||
| Note - ./crosscompile.bash omits debug symbols to keep the build smaller. | |||
|
|
|||
| ### Linux | |||
|
|
|||
| crosscompile currently can't target Linux, so you will need to manually build on | |||
There was a problem hiding this comment.
@oxtoacart If this is a known bug or limitation, could you please add a reference URL, an error message or a very short explanation on the reason?
|
Code looks fine and ready to merge, I've just added a tiny note on the documentation. |
xiam
added a commit
that referenced
this pull request
Feb 20, 2015
Integrating smaller lantern-ui into flashlight-build
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.