Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated background image for OS X dmg #83

Merged
merged 11 commits into from
Feb 22, 2015
Merged

Updated background image for OS X dmg #83

merged 11 commits into from
Feb 22, 2015

Conversation

oxtoacart
Copy link
Contributor

I also went ahead and vendored the rsrc tool that we use for embedding the icon in the windows executable.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.73% when pulling 14434fb on macbackground into cbcc8f4 on valencia.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.73% when pulling 4bec446 on macbackground into cbcc8f4 on valencia.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.73% when pulling 499081f on macbackground into cbcc8f4 on valencia.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.73% when pulling 499081f on macbackground into cbcc8f4 on valencia.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.73% when pulling dd355cf on macbackground into cbcc8f4 on valencia.

@atavism
Copy link

atavism commented Feb 22, 2015

Looks great! I noticed dragging Lantern to my Applications folder overwrites the previous version of Java Lantern I had installed. Is that the desired behavior? Just confirming.

@oxtoacart
Copy link
Contributor Author

I noticed dragging Lantern to my Applications folder overwrites the previous version of Java Lantern I had installed. Is that the desired behavior? Just confirming.

We basically punted on this by saying that we wouldn't worry about people who already had Lantern installed. If someone who had Lantern previously installed installs the new one, there will be other problems too (e.g. what happened to my whitelist customizations?!).

That said, yes, as implemented I would expect it to replace your existing Lantern since we're using the same name for the app, and I think that's a reasonable thing. The alternative would be calling it something else, but we couldn't agree on what to call it.

Either way, I'm really glad to be rid of the installer program on OS X, and I think Derek's background image looks great!

@atavism
Copy link

atavism commented Feb 22, 2015

We basically punted on this by saying that we wouldn't worry about people who already had Lantern installed. If someone who had Lantern previously installed installs the new one, there will be other problems too (e.g. what happened to my whitelist customizations?!).

Oh, good point! Yeah, that's the conclusion I thought we reached, but I just wanted to confirm.

Either way, I'm really glad to be rid of the installer program on OS X, and I think Derek's background image looks great!

+1! Looks great to me too. Merging!

atavism pushed a commit that referenced this pull request Feb 22, 2015
Updated background image for OS X dmg
@atavism atavism merged commit c3a0fba into valencia Feb 22, 2015
@atavism atavism deleted the macbackground branch February 22, 2015 17:21
@oxtoacart
Copy link
Contributor Author

Thanks for reviewing!

@myleshorton
Copy link
Contributor

Cool yeah and the overwriting of whatever old version of X program was there previously is standard behavior on OSX, so I think we're fine there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants