Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed trigger out of bounds panic, test all strategies w/ pcap file (file not included) #7

Merged
merged 3 commits into from
Mar 2, 2024

Conversation

garmr-ulfr
Copy link
Contributor

@garmr-ulfr garmr-ulfr commented Mar 1, 2024

Currently, to run TestApplyAllStrategies a pcap file must be added to internal/testdata/input.pcap. I didn't want to include the one I had as Hector sent it to me and I wasn't sure if it had sensitive information in it.

@garmr-ulfr
Copy link
Contributor Author

@Hector-Lantern, you should be able to use this branch inplace of main, temporarily, to run your tests again and see if these changes fixes the errors you were having.

@garmr-ulfr garmr-ulfr requested review from Crosse and hwh33 March 1, 2024 18:33
Copy link
Contributor

@Crosse Crosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment!

}
}

func TestApplyAllStrategies(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're not going to ship internal/testdata/input.pcap (and it makes sense to me why we're not right now), what do you think about adding t.Skip("no input.pcap file") at the head of this test so that it doesn't interfere with anyone running the tests after an initial clone?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Adding it.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8118626690

Details

  • 8 of 17 (47.06%) changed or added relevant lines in 3 files are covered.
  • 60 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-3.7%) to 54.928%

Changes Missing Coverage Covered Lines Changed/Added Lines %
triggers/tcp_trigger.go 0 2 0.0%
actions/tamper_action.go 7 14 50.0%
Files with Coverage Reduction New Missed Lines %
actions/actions.go 2 42.42%
geneva.go 4 0.0%
strategy/strategy.go 4 43.36%
internal/scanner/scanner.go 8 89.33%
actions/tamper_action.go 42 33.24%
Totals Coverage Status
Change from base Build 8071528533: -3.7%
Covered Lines: 758
Relevant Lines: 1380

💛 - Coveralls

@garmr-ulfr garmr-ulfr merged commit 4935a8c into main Mar 2, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants