Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't put huge buffers back into the pool #18

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Don't put huge buffers back into the pool #18

merged 1 commit into from
Oct 14, 2022

Conversation

oxtoacart
Copy link
Contributor

No description provided.

@oxtoacart oxtoacart requested a review from hwh33 October 14, 2022 00:27
@myleshorton
Copy link
Contributor

Would it be crazy to just delegate to zap within golog?

@oxtoacart
Copy link
Contributor Author

Would it be crazy to just delegate to zap within golog?

golog can already do that, see https://github.com/getlantern/golog/blob/master/zap_output.go#L8

@oxtoacart
Copy link
Contributor Author

Thanks for the review @myleshorton !

@oxtoacart oxtoacart merged commit 49749a7 into master Oct 14, 2022
@oxtoacart oxtoacart deleted the ox/bound-memory branch October 14, 2022 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myleshorton myleshorton myleshorton approved these changes

@hwh33 hwh33 Awaiting requested review from hwh33

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oxtoacart @myleshorton