Returning length 0 with EPIPE

getlantern · Jun 16, 2018 · 56314a2 · 56314a2
1 parent 3477e22
commit 56314a2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lampshade_test.go b/lampshade_test.go
@@ -115,8 +115,9 @@ func TestStreamCloseRemoteAfterEcho(t *testing.T) {
 	assert.Equal(t, io.EOF, err)
 	assert.Equal(t, 0, n)
 
-	_, err = conn.Write([]byte("whatever"))
+	n, err = conn.Write([]byte("whatever"))
 	assert.Equal(t, syscall.EPIPE, err, "Writing to the connection after the remote end already closed it should fail with an EPIPE")
+	assert.Equal(t, 0, n)
 
 	wg.Wait()
 }

diff --git a/sendbuffer.go b/sendbuffer.go
@@ -114,7 +114,7 @@ func (buf *sendBuffer) send(b []byte, writeDeadline time.Time) (int, error) {
 
 func (buf *sendBuffer) doSend(b []byte, writeDeadline time.Time) (int, error) {
 	if buf.closing {
-		return len(b), syscall.EPIPE
+		return 0, syscall.EPIPE
 	}
 
 	if writeDeadline.IsZero() {