Setting Host header in outgoing request, closes #3792 #3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,6 +35,9 @@ func (client *Client) newReverseProxy(bal *balancer.Balancer) *httputil.ReverseP | |||
| // field when upstream servers are trying to determine the client IP. | |||
| // We need to add also the X-Lantern-Device-Id field. | |||
| Director: func(req *http.Request) { | |||
| // Add back the Host header which was stripped by the ReverseProxy. This | |||
| // is needed for sites that do virtual hosting. | |||
| req.Header.Set("Host", req.Host) | |||
There was a problem hiding this comment.
It's definitely stripped before our Director function is called right @oxtoacart?
There was a problem hiding this comment.
Yes, it's stripped by the http.Server, which is using the ReverseProxy as a Handler, so by the time it gets to the ReverseProxy's logic, the header is already gone.
|
LGTM. |
myleshorton
added a commit
that referenced
this pull request
Mar 16, 2016
Setting Host header in outgoing request, closes #3792
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.