Consolidate feed code #4174
Merged
Consolidate feed code #4174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling f91674e on issue-4163-atavism into * on issue-4163*. |
added 2 commits
April 30, 2016 07:24
|
Changes Unknown when pulling 4255c98 on issue-4163-atavism into * on issue-4163*. |
|
Oh cool @atavism yeah I wanted to do that but wanted to make sure to not mess up the interface to your stuff on the java side. I should be able to look at this today! In the latest version on my branch I also made a new "feed" package in flashlight, but maybe that's exactly what you did. I'll have a look. Good stuff! |
|
Looks great @atavism thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@myleshorton With your changes for #4167, instead of having a separate
feed.goin the lantern package, I'm combining it here with yours.