Few fixes for building on Windows. #4200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| S3CMD := $(shell which s3cmd 2> /dev/null) | ||
| WGET := $(shell which wget 2> /dev/null) | ||
| RUBY := $(shell which ruby 2> /dev/null) | ||
| get-command = $(shell which="$$(which $(1) 2> /dev/null)" && if [[ ! -z "$$which" ]]; then printf %q "$$which"; fi) |
There was a problem hiding this comment.
My Windows setup was on a path that contained spaces and that was interfering with the $(NPM) target $(RESOURCES_DOT_GO) depended on. I ended up removing the $(NPM) target in favour of a descriptive message but I also fixed the problems with spaces on command names by passing them through printf %q.
xiam
changed the title
|
These look good to me @xiam. Merging. |
oxtoacart
pushed a commit
that referenced
this pull request
Apr 28, 2020
Few fixes for building on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @oxtoacart, I initially could not make the thing work, I had to make a few changes, could you take a look at them?