Added copying of headers to the fronted request closes #4246 #4247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK @oxtoacart I think this should be all set. I went ahead and refactored things a little bit to make testing easier. |
|
Hey one sec @oxtoacart just realized the test needs a little work.. |
|
@myleshorton Ok, just let me know when you want me to take a look. |
| // Make a copy of the original requeest headers to include in the fronted | ||
| // request. This will ensure that things like the caching headers are | ||
| // included in both requests. | ||
| headersCopy := make(http.Header, len(req.Header)) |
There was a problem hiding this comment.
Small nit, but there's no point in copying if the frontedURL check fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.