-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stripping out new analytics to return things back to normal closes #4315 #4316
Conversation
This just strips out most of the changes in 2.2.x to return analytics back to their previous state. This reflects several things, including that non-interaction hits are handled very differently (apparently) and that the Lantern version actually proved to be very useful in identifying fake versions. |
Hey @oxtoacart you mind taking a look at this -- I just realized our analytics are still pretty messed up! |
It looks like the coverage changes are just based on randomly touched code in the tests @oxtoacart so tempted to ignore. |
transport func(string, eventual.Getter)) func() { | ||
var addr atomic.Value | ||
go func() { | ||
logging.AddUserAgentListener(func(agent string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@myleshorton With this change, the AddUserAgentListener capability is no longer used. Can you remove it and the corresponding test please?
Yup all set @oxtoacart! |
Code LGTM, just waiting for tests to pass. |
Thanks @oxtoacart! I'll add this on devel as well. |
No description provided.