Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will there be serverless v4 compatibility? #393

Open
cmcnicholas opened this issue May 25, 2024 · 11 comments
Open

Will there be serverless v4 compatibility? #393

cmcnicholas opened this issue May 25, 2024 · 11 comments
Labels
enhancement New feature or request

Comments

@cmcnicholas
Copy link
Contributor

Start from the Use-case

Serverless v4 is here. https://github.com/serverless/serverless/releases/tag/v4.0.26

Example Config

No response

Implementation Idea

No response

@cmcnicholas cmcnicholas added the enhancement New feature or request label May 25, 2024
@mnapoli
Copy link
Member

mnapoli commented May 27, 2024

Is that incompatible at the moment? Do you get any error?

@cmcnicholas
Copy link
Contributor Author

Is that incompatible at the moment? Do you get any error?

Just the version dependency currently.

"serverless": "^3.28.0",

@mnapoli
Copy link
Member

mnapoli commented May 27, 2024

Understood, we can definitely relax that 👍 Before doing so, it would be great to get confirmation that it works fine :)

@austencollins
Copy link

FWIW our intention is to support the Lift plugin in Serverless Framework V.4, as always. We've done some testing recently and discovered a bug. We're working on a fix now and tracking it here: serverless/serverless#12571

@rj-xy
Copy link

rj-xy commented Jun 5, 2024

For anyone looking for a work-around for this, pinning serverless to the latest v3 gets around this issue for the moment, but not ideal.

@austencollins
Copy link

Lift should work seamlessly with V.4 now as of this release. We are continuing to test and monitor everything. Please let us know if you see further issues.

@dohomi
Copy link

dohomi commented Jun 15, 2024

I just started using lift with serverless and struggling with npm dependencies and layers. I use following v4 config:

build:
  esbuild:
    bundle: true
    minify: false
    target: node20
    packages: external

constructs:
  drawing-queue:
    type: queue
    worker:
      handler: src/drawing/worker.handler
      layers:
        - arn:aws:lambda:xxx:layer:chromiumLayer:3
        - arn:aws:lambda:xxx:layer:sharpLayer:2

I bump into the issue that defined layers of construct fields of the yaml not work as expected, also the npm dependencies seem not to work or doesnt seemp to be bundled as the other functions. Am I missing something?

Just to make sure: the dependencies and layers work in the function calls, but I want to make the switch to queue as some tasks are running too long.

@Vakintoshka
Copy link

hey guys, any updates on it? it's still impossible to npm install lift with serverless v4

@mnapoli
Copy link
Member

mnapoli commented Aug 26, 2024

serverless/serverless#12571 still mentions issues, can anyone confirm whether Lift works with v4?

Also PRs are welcome.

@skierkowski
Copy link

@Vakintoshka Can you elaborate on the install issue you are seeing? If you are seeing the error with a serverless command, can you run serverless support --github and share the output.

@skierkowski
Copy link

@mnapoli Hi 👋 , long time! Yes, Serverless Framework v4 works with Lift. I'm confirming this based on analytics and testing. Having said that, there may still be some issues, like the one mentioned in the issue you linked, and the install issue @Vakintoshka mentioned. I'm trying to get the repro steps so we can fix them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants