feat(single-page-app): add pdf to redirect regex #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but I think the tests need to be updated too 👍 |
GuillaumeLagrange
force-pushed
the
single-page-app-static-pdf
branch
from
9b17532
to
3d08a93
Compare
|
Indeed, should have caught that locally 👍 Fixed locally, pipeline should be good now |
fredericbarthelet
approved these changes
May 3, 2022
|
LGTM, thanks @GuillaumeLagrange |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to serve a pdf as a static file with the single page app contruct, the cloudfront distribution would redirect to index.html because the pdf file extension was not whitelisted.
This PR adds the pdf file extension to the whitelist so that users can serve pdf files statically.