Expose assets bucket name to static-website and single-page-app #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this PR. @fredericbarthelet given we merged #241 I think it makes sense to merge this one too (same variable), WDYT? |
|
@mnapoli agreed :) @MarcEspiard, could you update your branch to latest version of master ? We recently shipped a fix that should allow tests with latest version of serverless to pass on your PR :) |
fredericbarthelet
approved these changes
Mar 2, 2023
|
@fredericbarthelet Thank you for that, just updated with latest changes from master. |
|
@MarcEspiard published in 1.24.0 Thanks for your contribution :) |
|
@fredericbarthelet no worries, bonne journée :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Similar to #241, exposing the assets bucket name for the static website and spa constructs.
My use case:
I want to trigger an event after objects are created in the bucket so a Lambda can add some metadata to each file uploaded in that folder (Cache Control headers etc...)