Rewrite disable auto permission test #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serverless v3.28.0 updates permissions given to lambda to be able to use a new logs:TagResource action on Cloudwatch groups. Rewriting the test to ensure no permission regarding s3 are added to lambda instead of checking exact Action match assertions, in order to have tests passing both for serverless v2 and latest v3
fredericbarthelet
deleted the
update-tests-with-new-serverless-permissions
branch
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serverless v3.28.0 updates permissions given to lambda to be able to use a new logs:TagResource action on Cloudwatch groups. Rewriting the test to ensure no permission regarding s3 are added to lambda instead of checking exact Action match assertions, in order to have tests passing both for serverless v2 and latest v3
PR made on Serverless v3.28.0 that introduce this change : serverless/serverless#11766