Gracefully handle redirectToMainDomain with only a single domain #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are failing, any idea why? |
I believe these should all be good to go now :) |
mnapoli
reviewed
May 3, 2023
| @@ -372,7 +372,7 @@ export class ServerSideWebsite extends AwsConstruct { | |||
| private createRequestFunction(): cloudfront.Function { | |||
| let additionalCode = ""; | |||
|
|
|||
| if (this.configuration.redirectToMainDomain === true) { | |||
| if (this.configuration.redirectToMainDomain === true && this?.domains && this.domains.length > 1) { | |||
There was a problem hiding this comment.
The build still fails, could it be that this? is invalid because this cannot be null?
aran112000
force-pushed
the
server-side-website-improvements
branch
from
972ed7c
to
71b1580
Compare
Far better way to handle the same solution. Plus it fixes the CI
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've run into issues with dynamic configs which are stage-dependent - different stages have different domain(s).
This change allows the directive to be present but will silence its behaviour where only a single domain has been specified.