Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQS DLQ alarm should treat missing data as not breaching #337

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

chrishanline
Copy link
Contributor

https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-monitoring-using-cloudwatch.html

When an Amazon SQS queue is inactive for more than six hours, the Amazon SQS service is considered asleep and stops delivering metrics to the CloudWatch service. Missing data, or data representing zero, can't be visualized in the CloudWatch metrics for Amazon SQS for the time period that your Amazon SQS queue was inactive.

Because of this, the DLQ alarms currently created by lift will show Insufficient data most of the time when the queue they monitor are empty and inactive.

dlq cw alarms

This PR sets treatMissingData to notBreaching on the alarm vs the current CDK default of missing. notBreaching will allow an inactive (and thus empty) SQS queue to show Ok when browsing alarms.

@mnapoli
Copy link
Member

mnapoli commented Jun 16, 2023

Thank you!

@mnapoli mnapoli merged commit aaa3588 into getlift:master Jun 16, 2023
14 checks passed
@chrishanline chrishanline deleted the dlq-alarm-missing-data branch June 16, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants