Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the default global handler #141

Closed
vmalloc opened this issue Jun 21, 2015 · 9 comments
Closed

Remove the default global handler #141

vmalloc opened this issue Jun 21, 2015 · 9 comments
Assignees

Comments

@vmalloc
Copy link
Collaborator

vmalloc commented Jun 21, 2015

This is a tough one.

One of the problems with Logbook today that is hindering its adoption is, in my opinion, the default global handler.

While very useful for quick apps or webapps, it is an annoyance to library developers -- each library explicitly or implicitly using Logbook means output to stderr by default.

Given the fact that setting up logbook is so easy (especially compared to basicConfig), I think dropping the default global handler is a wise move. Application seeking to add it back need a single line in their if __name__ == 'main' section, while libraries can rest assured that they don't litter the screen by default.

However I won't go forward making the change before I hear some more opinions about it - @brainstorm or anyone else, please let me know what you think...

@vmalloc vmalloc self-assigned this Jun 21, 2015
@brainstorm
Copy link
Contributor

That indeed sounds like a good move, specially if we want third party libs to start using Logbook more. As long as the docs are clear on those two use cases, I see no reason to go for it. Well thought @vmalloc!

@vmalloc
Copy link
Collaborator Author

vmalloc commented Jun 22, 2015

@brainstorm who else do we want to involve in this decision? I'm trying to avoid a massive rage once we bump a version with this change...

@brainstorm
Copy link
Contributor

Other than upstream's @mitsuhiko, who I guess is packed right now with other projects and decisions, I cannot think of anyone else...

@vmalloc
Copy link
Collaborator Author

vmalloc commented Jun 22, 2015

I posted a message in #pocoo, but nobody seemed to respond, so I guess I'll just make the change if nobody objects within a few days...

@brainstorm
Copy link
Contributor

👍

@vmalloc
Copy link
Collaborator Author

vmalloc commented Jun 22, 2015

@brainstorm why close the issue?

@vmalloc vmalloc reopened this Jun 22, 2015
@brainstorm
Copy link
Contributor

Oops, sorry, my bad :-S

@brainstorm
Copy link
Contributor

So this one got in for 0.11 at the end, right?

@vmalloc
Copy link
Collaborator Author

vmalloc commented Oct 6, 2015

To 0.10. Forgot to close :-)

@vmalloc vmalloc closed this as completed Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants