Enhance the paged mode reader #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkalexling
reviewed
Aug 19, 2021
public/js/reader.js
Outdated
| @@ -52,6 +54,16 @@ const readerComponent = () => { | |||
| if (savedMargin) { | |||
| this.margin = savedMargin; | |||
| } | |||
|
|
|||
| // Preload Images | |||
| this.preloadLookahead = +localStorage.getItem('preloadLookahead') ?? 3; | |||
There was a problem hiding this comment.
When the key doesn't exist in local storage, getItem returns null, but the + sign turns it into 0 (because +null evaluates to 0). I think we can remove the plus sign here?
There was a problem hiding this comment.
I see! Since getItem() returns a string and I want to keep this.preloadLookahead as a number, I'll parenthesize them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Preload next images
This resolve #196
Preload lookahead: 3 pages
Started from p32, it preloaded next 3 pages (pp.33-35)
After reading p33 and p34, it preloaded p36, p37 each.
2. Prevent to load unnecessary images
Fix #217
3. Fix CSS to fit image 'contain' properly
Fix #218
4. Option for enabling/disabling a flip animation
This resolve one of suggestion from #147
A below picture shows a modal menu when the mode is paged mode.
It has the checkbox for toggling flip animation and the range input to set preload pages
I'm curious that its layout looks good (especially about a position of the checkbox... 馃槣)