-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom domains don't work for branch deploys #165
Comments
The original goal for the custom domains was to set the "production" domain for the site while the original goal for the branches was to allow the preview of the "non-prod" versions (beta, demo...). Which is why it is currently not working correctly. It does however make sense to add the branches to the custom domains in certain cases. So we're going to:
After this change, the user will need to:
|
@queicherius so sorry it took this long to get on this, but I'm on it 😄 |
# [1.0.0-beta.14](v1.0.0-beta.13...v1.0.0-beta.14) (2021-01-13) ### Bug Fixes * missing await in org list ([ea5c456](ea5c456)) * missing await in org member serializer ([7617d86](7617d86)) * sites not serialized properly ([eb8ee20](eb8ee20)) * team sites not serialized properly ([e215f0e](e215f0e)) ### Features * expose branches on custom domains [#165](#165) ([46f3de3](46f3de3)) * logos ([#183](#183)) ([0074e42](0074e42)) * show logo to invites and org members ([c5791fe](c5791fe))
@queicherius i'm closing, but please let me know if further help is needed, happy to help 😀 |
I have setup DNS records (A) for
project.company.io
and*.project.company.io
, pointing at the Meli IP.I then added
project.company.io
into the "Domains" section of the site settings. This now works perfectly forproject.company.io
itself, pointing towards the main branch.However, if I call
branch.project.company.io
, I get aERR_SSL_PROTOCOL_ERROR
, with a "no server TLS configuration available" error.This is fixable, if I add
*.project.company.io
to the domains in the site settings, but I feel like this either requires some docs or should happen automatically.The text was updated successfully, but these errors were encountered: