Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar doesn't update unless page refreshed #194

Closed
tanc opened this issue Feb 19, 2021 · 3 comments
Closed

Sidebar doesn't update unless page refreshed #194

tanc opened this issue Feb 19, 2021 · 3 comments
Assignees
@gempain
Labels
bug Something isn't working
Projects
main

Comments

@tanc
Copy link
Contributor

tanc commented Feb 19, 2021

Minor UI issue: when creating a new site or editing an existing one the sidebar doesn't reflect the changes until the page is manually refreshed.

To reproduce:

  1. Create a site
  2. Edit the site settings
  3. Change the associated colour
  4. Save the site's settings form
  5. Note that the colour in the sidebar doesn't change
  6. Reload the page
  7. Note the the colour in the sidebar has changed
@gempain
Copy link
Contributor

gempain commented Feb 22, 2021

@tanc thanks for the issue ! At the moment, we don't have a state management library in the React frontend (getmeli/meli-ui. We're still considering various options, and as we are planing to move to GraphQL in the mid-term, we were waiting for a decision before moving forward with a fix. That said, I recognize this is a bit odd, when you add a site and it doesn't appear in the sidebar until you refresh the page. We'll see what we can do to mitigate.

@gempain gempain added the bug Something isn't working label Feb 22, 2021
@gempain gempain changed the title Issue: Sidebar doesn't update unless page refreshed Sidebar doesn't update unless page refreshed Feb 22, 2021
gempain pushed a commit that referenced this issue Mar 8, 2021
feat: add websocket handler #194
2aad514
@gempain
Copy link
Contributor

gempain commented Mar 8, 2021

@tanc this is fixed in version next, but we'll release in the coming days.

@gempain gempain self-assigned this Mar 8, 2021
@gempain gempain added this to Done in main Mar 9, 2021
gempain pushed a commit that referenced this issue Mar 10, 2021
@semantic-release-bot
chore(release): 1.0.0-beta.17 [skip ci]
43b000e 
# [1.0.0-beta.17](v1.0.0-beta.16...v1.0.0-beta.17) (2021-03-10)

### Bug Fixes

* error when unhandled socket event ([3e0151a](3e0151a))
* req.query not typed ([581e3ca](581e3ca))
* socket io protocol error ([6e414a0](6e414a0))
* **add branch:** should not update release when no id given ([b3b25e8](b3b25e8))

### Features

* add websocket handler [#194](#194) ([2aad514](2aad514))
* change api scope formats ([#200](#200)) ([ed34896](ed34896))
* configure gzip compression ([#195](#195)) ([bc5e3ff](bc5e3ff))
* custom headers per branch or site ([#195](#195)) ([c8645a7](c8645a7))
* forbid underscores in site name ([#193](#193)) ([f263f09](f263f09))
* set cache-control header ([#195](#195)) ([09621ea](09621ea))

### BREAKING CHANGES

* all API tokens currently in use will be invalidated.
@gempain
Copy link
Contributor

gempain commented Mar 10, 2021

This was released on beta. I'm closing, but feel free to comment and we'll reopen if needed.

@gempain gempain closed this as completed Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gempain gempain

Labels
bug Something isn't working
Projects
main
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tanc @gempain