Skip to content

Commit

Permalink
S3: Sending notification to EventBridge `OBJECT_CREATED_COMPLETE_MULT…
Browse files Browse the repository at this point in the history
…IPART_UPLOAD_EVENT` (#7435)
  • Loading branch information
tsugumi-sys committed Mar 8, 2024
1 parent 643c0da commit 4fc45e7
Show file tree
Hide file tree
Showing 2 changed files with 63 additions and 1 deletion.
7 changes: 7 additions & 0 deletions moto/s3/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -2455,6 +2455,13 @@ def complete_multipart_upload(
key_name=key.name,
acl=multipart.acl,
)

notifications.send_event(
self.account_id,
notifications.S3NotificationEvent.OBJECT_CREATED_COMPLETE_MULTIPART_UPLOAD_EVENT,
bucket,
bucket.keys.get(multipart.key_name),
)
return key

def get_all_multiparts(self, bucket_name: str) -> Dict[str, FakeMultipart]:
Expand Down
57 changes: 56 additions & 1 deletion tests/test_s3/test_s3_eventbridge_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,15 @@

from moto import mock_aws, settings
from moto.core import DEFAULT_ACCOUNT_ID as ACCOUNT_ID
from moto.settings import S3_UPLOAD_PART_MIN_SIZE
from tests.test_s3.test_s3_multipart import reduced_min_part_size

REGION_NAME = "us-east-1"
REDUCED_PART_SIZE = 256

if settings.TEST_DECORATOR_MODE:
REDUCED_PART_SIZE = 256
else:
REDUCED_PART_SIZE = S3_UPLOAD_PART_MIN_SIZE


def _seteup_bucket_notification_eventbridge(
Expand Down Expand Up @@ -144,6 +149,56 @@ def test_copy_object_notification():
assert event_message["detail"]["reason"] == "ObjectCreated"


@mock_aws
@reduced_min_part_size
def test_complete_multipart_upload_notification():
resource_names = _seteup_bucket_notification_eventbridge()
bucket_name = resource_names["bucket_name"]
s3_client = boto3.client("s3", region_name=REGION_NAME)
object_key = "testkey"

part1 = b"0" * REDUCED_PART_SIZE
part2 = b"1"
multipart = s3_client.create_multipart_upload(Bucket=bucket_name, Key=object_key)
up1 = s3_client.upload_part(
Body=BytesIO(part1),
PartNumber=1,
Bucket=bucket_name,
Key=object_key,
UploadId=multipart["UploadId"],
)
up2 = s3_client.upload_part(
Body=BytesIO(part2),
PartNumber=2,
Bucket=bucket_name,
Key=object_key,
UploadId=multipart["UploadId"],
)

s3_client.complete_multipart_upload(
Bucket=bucket_name,
Key=object_key,
MultipartUpload={
"Parts": [
{"ETag": up1["ETag"], "PartNumber": 1},
{"ETag": up2["ETag"], "PartNumber": 2},
]
},
UploadId=multipart["UploadId"],
)

events = _get_send_events()
assert len(events) == 2 # [PutObject event, CompleteMultipartUpload event]
event_message = json.loads(events[-1]["message"])
assert event_message["detail-type"] == "Object Created"
assert event_message["source"] == "aws.s3"
assert event_message["account"] == ACCOUNT_ID
assert event_message["region"] == REGION_NAME
assert event_message["detail"]["bucket"]["name"] == bucket_name
assert event_message["detail"]["object"]["key"] == object_key
assert event_message["detail"]["reason"] == "ObjectCreated"


@mock_aws
def test_delete_object_notification():
resource_names = _seteup_bucket_notification_eventbridge()
Expand Down

0 comments on commit 4fc45e7

Please sign in to comment.