Better EC2 duplicate SG error.

getmoto · Mar 16, 2017 · 8a803cd · 8a803cd
1 parent 5f3fbff
commit 8a803cd
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/moto/ec2/exceptions.py b/moto/ec2/exceptions.py
@@ -156,6 +156,14 @@ def __init__(self):
             "The specified rule does not exist in this security group")
 
 
+class InvalidPermissionDuplicateError(EC2ClientError):
+
+    def __init__(self):
+        super(InvalidPermissionDuplicateError, self).__init__(
+            "InvalidPermission.Duplicate",
+            "The specified rule already exists")
+
+
 class InvalidRouteTableIdError(EC2ClientError):
 
     def __init__(self, route_table_id):

diff --git a/moto/ec2/models.py b/moto/ec2/models.py
@@ -35,6 +35,7 @@
     InvalidSecurityGroupDuplicateError,
     InvalidSecurityGroupNotFoundError,
     InvalidPermissionNotFoundError,
+    InvalidPermissionDuplicateError,
     InvalidRouteTableIdError,
     InvalidRouteError,
     InvalidInstanceIdError,
@@ -1311,7 +1312,7 @@ def get_cfn_attribute(self, attribute_name):
 
     def add_ingress_rule(self, rule):
         if rule in self.ingress_rules:
-            raise InvalidParameterValueError('security_group')
+            raise InvalidPermissionDuplicateError()
         else:
             self.ingress_rules.append(rule)