Remove pkg_resources module #4142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yay! thanks! |
|
This is now part of moto >= 2.2.2.dev20 |
|
Nice! I had recommended setuptools be vanquished.. it's nice to see this was resolved. |
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Aug 20, 2021
Noticed this after reading getmoto/moto#4142 Ref: aws/aws-xray-sdk-python#306 git-svn-id: file:///srv/repos/svn-community/svn@1003952 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Aug 20, 2021
Noticed this after reading getmoto/moto#4142 Ref: aws/aws-xray-sdk-python#306 git-svn-id: file:///srv/repos/svn-community/svn@1003952 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Aug 20, 2021
Ref: getmoto/moto#4142 git-svn-id: file:///srv/repos/svn-community/svn@1003964 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Aug 20, 2021
Ref: getmoto/moto#4142 git-svn-id: file:///srv/repos/svn-community/svn@1003964 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the
setuptoolsdependency was removed, thepkg_resources-module is no longer available to Moto.This PR rewrites all functionality that depended on pkg_resources, to instead use the
importlib_metadataandpgkdata-modules.It also explicitly removes the
pkg_resources-module from the dependency test, to ensure it works.(Note: XRay has an implicit dependency on pkg_resources, so we're adding setuptools back to that module only.)
(Note 2: For Py3.8, we could start using the buildin
importlib.metadata, but for we'll need the backport for 3.6 and 3.7.)Successful dependency test: https://github.com/bblommers/moto/runs/3253699280?check_suite_focus=true