Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WAFv2 URLs with proper regex #4237

Merged
merged 1 commit into from
Aug 28, 2021
Merged

Update WAFv2 URLs with proper regex #4237

merged 1 commit into from
Aug 28, 2021

Conversation

bblommers
Copy link
Collaborator

Follow up to #4110

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2021

Codecov Report

Merging #4237 (6b47c8e) into master (07bb843) will increase coverage by 40.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4237       +/-   ##
===========================================
+ Coverage   54.91%   95.13%   +40.21%     
===========================================
  Files         485      485               
  Lines       54129    54129               
===========================================
+ Hits        29723    51493    +21770     
+ Misses      24406     2636    -21770     
Flag Coverage Δ
servertests 54.91% <ø> (ø)
test_responses 32.89% <ø> (?)
unittests 95.03% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
moto/wafv2/urls.py 100.00% <ø> (ø)
moto/ec2/responses/route_tables.py 100.00% <0.00%> (+1.23%) ⬆️
moto/ec2/responses/network_acls.py 100.00% <0.00%> (+1.40%) ⬆️
moto/ec2/responses/elastic_ip_addresses.py 98.41% <0.00%> (+1.58%) ⬆️
moto/rds/responses.py 90.59% <0.00%> (+1.70%) ⬆️
moto/dynamodb2/parsing/validators.py 97.93% <0.00%> (+2.06%) ⬆️
moto/ec2/responses/internet_gateways.py 100.00% <0.00%> (+2.22%) ⬆️
moto/sqs/utils.py 95.34% <0.00%> (+2.32%) ⬆️
moto/ec2/responses/vpn_connections.py 89.74% <0.00%> (+2.56%) ⬆️
moto/ec2/responses/security_groups.py 89.05% <0.00%> (+3.64%) ⬆️
... and 247 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07bb843...6b47c8e. Read the comment docs.

@bblommers bblommers merged commit a43c42e into master Aug 28, 2021
@bblommers bblommers deleted the patch-wafv2-url-fix branch August 28, 2021 14:26
@bblommers bblommers added this to the 2.2.6 milestone Aug 28, 2021
@github-actions
Copy link
Contributor

This is now part of moto >= 2.2.6.dev23

sahilshah6196 pushed a commit to EBSCOIS/moto that referenced this pull request Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants