Fix interoperability with responses 0.17.0 #4749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bblommers
force-pushed
the
fix/responses-17
branch
2 times, most recently
from
bf0a578
to
e344604
Compare
bblommers
force-pushed
the
fix/responses-17
branch
from
e344604
to
45e6853
Compare
|
This is now part of moto >= 2.3.2.dev2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts all the custom responses-logic into a dedicated file
Adds a CustomRegistry that works with 0.17.0
Test more versions of
responses, to ensure Moto works with every possible versionChanges the
responses.reset()toresponses.calls.reset(), to ensure that our custom registry and passthru-prefixes are not being reset.Related PR where the possibility of using the CustomRegistry was raised: #4657