fixed tf-tests: TestAccRoute53Zone, TestAccRoute53ZoneDataSource #5229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macnev2013
changed the title
bblommers
reviewed
Jun 15, 2022
| zone_list.append( | ||
| { | ||
| "HostedZoneId": this_id, | ||
| "HostedZoneId": zone.id, |
There was a problem hiding this comment.
Did you verify this against AWS @macnev2013? The docs for get_hosted_zone specifically say that the output should follow this format, but nothing about the format in list_hosted_zones_by_vpc
There was a problem hiding this comment.
Yes. you can check this doc here.
Also verified it with terraform.
There was a problem hiding this comment.
Gotcha. It looks good to me - happy to merge once the unit tests pass
bblommers
approved these changes
Jun 15, 2022
|
This is now part of moto >= 3.1.14.dev10 |
whummer
pushed a commit
to localstack/moto
that referenced
this pull request
Jun 22, 2022
sahilshah6196
pushed a commit
to EBSCOIS/moto
that referenced
this pull request
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TF Tests
Fixed