EC2: create_route() should allow overlapping CIDR's #6106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6096
Partially reverts #5233
@mmerrill3 Do you remember the details about the linked PR that you raised? From my testing, overlapping CIDR's are allowed - as long as it's not a direct match.
The docs even mention this scenario, and explain what happens when overlapping routes exist: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2/client/create_route.html
Just wanted to know whether there was a specific reason that you added this check, maybe I missed some important details in my testing.