New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECS: add pidMode validation for FARGATE #6825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cm-iwata! Looks like the linter is failing: https://github.com/getmoto/moto/actions/runs/6222529602/job/16886668644
@bblommers |
Codecov Report
@@ Coverage Diff @@
## master #6825 +/- ##
==========================================
- Coverage 96.20% 96.20% -0.01%
==========================================
Files 816 816
Lines 80034 80045 +11
==========================================
+ Hits 76998 77007 +9
- Misses 3036 3038 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome - thank you!
This is now part of moto >= 4.2.4.dev12 |
ECS on FARGATE only allows
task
for pidModehttps://docs.aws.amazon.com/AmazonECS/latest/userguide/task_definition_parameters.html