Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS: add pidMode validation for FARGATE #6825

Merged
merged 3 commits into from Sep 19, 2023

Conversation

cm-iwata
Copy link
Contributor

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cm-iwata
Copy link
Contributor Author

@bblommers
Fixed lint error that relate this PR.
I'm still getting a lint error, but this is not related to this PR.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #6825 (cf3b9ae) into master (fb9023a) will decrease coverage by 0.01%.
Report is 12 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6825      +/-   ##
==========================================
- Coverage   96.20%   96.20%   -0.01%     
==========================================
  Files         816      816              
  Lines       80034    80045      +11     
==========================================
+ Hits        76998    77007       +9     
- Misses       3036     3038       +2     
Flag Coverage Δ
servertests 37.01% <0.00%> (-0.01%) ⬇️
unittests 96.14% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
moto/ecs/models.py 93.84% <100.00%> (+0.01%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thank you!

@bblommers bblommers added this to the 4.2.3 milestone Sep 19, 2023
@bblommers bblommers merged commit 2ada07f into getmoto:master Sep 19, 2023
82 checks passed
@cm-iwata cm-iwata deleted the feat/fargate-pidmode branch September 19, 2023 13:03
@github-actions
Copy link
Contributor

This is now part of moto >= 4.2.4.dev12

@bblommers bblommers modified the milestones: 4.2.3, 4.2.4 Sep 22, 2023
toshyak pushed a commit to toshyak/moto that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants