EC2: launch templates created by CloudFormation have a generated name if not provided #7135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skinitimski
commented
Dec 18, 2023
| @@ -233,6 +233,10 @@ def random_launch_template_id() -> str: | |||
| return random_id(prefix=EC2_RESOURCE_TO_PREFIX["launch-template"], size=17) | |||
|
|
|||
|
|
|||
| def random_launch_template_name() -> str: | |||
| return f"LaunchTemplate_{random_resource_id(size=12)}" | |||
There was a problem hiding this comment.
This is not quite right, it is closer to what is produced by cloudformation.utils.random_suffix -- but importing random_suffix is circular.
This is probably close enough.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7135 +/- ##
=======================================
Coverage 95.87% 95.88%
=======================================
Files 834 834
Lines 82233 82237 +4
=======================================
+ Hits 78844 78850 +6
+ Misses 3389 3387 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bblommers
approved these changes
Dec 18, 2023
bblommers
changed the title
|
This is now part of moto >= 4.2.13.dev3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes a bug in the creation of launch templates via CloudFormation. If your template has more than one unnamed launch template, creation will fail with
This is because moto's implementation expects that the resource have a
LaunchTemplateNameproperty even though it is optional.