Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep release 5.0.3 #7447

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Prep release 5.0.3 #7447

merged 1 commit into from
Mar 9, 2024

Conversation

bblommers
Copy link
Collaborator

Enable TF EC2 tests. We only want to create them, not create/update/delete like the others, so it is a separate action
Fix a bug in SQS where it should be possible to send a message to a FIFO-queue without specifying a DelaySeconds-argument
Change the implementation coverage script to explicitly pickup S3.upload_file. It is not part of the botocore-spec, like every other feature, so we have to treat it differently.

@bblommers bblommers added this to the 5.0.3 milestone Mar 8, 2024
@bblommers bblommers force-pushed the prep/5.0.3 branch 2 times, most recently from 7c58db6 to 17d9fba Compare March 9, 2024 21:07
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.80%. Comparing base (9aef694) to head (d7d798f).
Report is 89 commits behind head on master.

Files Patch % Lines
moto/s3/models.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7447      +/-   ##
==========================================
- Coverage   95.88%   95.80%   -0.08%     
==========================================
  Files         843      849       +6     
  Lines       82578    83717    +1139     
==========================================
+ Hits        79178    80205    +1027     
- Misses       3400     3512     +112     
Flag Coverage Δ
servertests 32.30% <60.00%> (-0.22%) ⬇️
unittests 95.77% <60.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers merged commit e3330af into getmoto:master Mar 9, 2024
39 of 40 checks passed
@bblommers bblommers deleted the prep/5.0.3 branch March 9, 2024 21:39
Copy link
Contributor

github-actions bot commented Mar 9, 2024

This is now part of moto >= 5.0.3.dev60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant