Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed secretsmanager list api to support filtering correctly #7511

Merged
merged 3 commits into from Mar 26, 2024

Conversation

macnev2013
Copy link
Contributor

@macnev2013 macnev2013 commented Mar 22, 2024

Motivation

This PR addresses the issue in the list operation of Secrets Manager where filters were incorrectly applied to the entire key rather than just the prefix.

Issue

Previously, filters were matched against the entire key, which is incorrect. The correct behavior is to match filters against the prefix only.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.06%. Comparing base (9aef694) to head (8e22a1c).
Report is 136 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7511      +/-   ##
==========================================
- Coverage   95.88%   94.06%   -1.82%     
==========================================
  Files         843     1070     +227     
  Lines       82578    91824    +9246     
==========================================
+ Hits        79178    86377    +7199     
- Misses       3400     5447    +2047     
Flag Coverage Δ
servertests 29.57% <21.42%> (-2.96%) ⬇️
unittests 94.03% <100.00%> (-1.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@macnev2013
Copy link
Contributor Author

Hi @bblommers, can you retrigger the pipeline? It seems the CI is failing due to unrelated changes.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for fixing this @macnev2013!

@bblommers bblommers added this to the 5.0.4 milestone Mar 26, 2024
@bblommers bblommers merged commit 31b971f into getmoto:master Mar 26, 2024
39 of 40 checks passed
Copy link
Contributor

This is now part of moto >= 5.0.4.dev47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants