Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Data Brew Recipe Latest Working Version Create Date #7667

Merged
merged 1 commit into from
May 11, 2024

Conversation

runstache
Copy link
Contributor

Corrects an issue where the Create Date of the Latest Working version remains the same as the published version. This should be the Publish Date as observed through interactions with AWS API Interactions for Publish Recipe.

Steps:

  • Added field setting in moto/databrew/models.py
  • Updated Publish Recipe Tests to compare publish date and latest working create date

Issues Addressed:

Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.29%. Comparing base (9093b78) to head (ce6c6d2).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7667      +/-   ##
==========================================
- Coverage   94.29%   94.29%   -0.01%     
==========================================
  Files        1086     1086              
  Lines       92356    92293      -63     
==========================================
- Hits        87090    87028      -62     
+ Misses       5266     5265       -1     
Flag Coverage Δ
servertests 29.47% <0.00%> (+0.01%) ⬆️
unittests 94.26% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for the fix @runstache!

@bblommers bblommers added this to the 5.0.7 milestone May 11, 2024
@bblommers bblommers merged commit 9394878 into getmoto:master May 11, 2024
40 checks passed
Copy link
Contributor

This is now part of moto >= 5.0.7.dev38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Brew Recipe Publish does not update Create Date on Latest Working Copy
2 participants