Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Techdebt: DynamoDB: Simplify validation for CreateTable #7669

Merged

Conversation

bblommers
Copy link
Collaborator

Behaviour stays the same, but this will make it easier to reuse the validation in the future

@bblommers bblommers added this to the 5.0.7 milestone May 5, 2024
Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.29%. Comparing base (9093b78) to head (61bf619).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7669      +/-   ##
==========================================
- Coverage   94.29%   94.29%   -0.01%     
==========================================
  Files        1086     1086              
  Lines       92356    92293      -63     
==========================================
- Hits        87090    87028      -62     
+ Misses       5266     5265       -1     
Flag Coverage Δ
servertests 29.47% <4.16%> (+0.01%) ⬆️
unittests 94.26% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers merged commit 6e3b2e8 into getmoto:master May 5, 2024
40 checks passed
@bblommers bblommers deleted the dynamodb/refactor-table-validation branch May 5, 2024 19:27
Copy link
Contributor

github-actions bot commented May 5, 2024

This is now part of moto >= 5.0.7.dev28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant