Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS: update_service reflects correct counts #7714

Merged
merged 1 commit into from
May 24, 2024

Conversation

rafcio19
Copy link
Contributor

@rafcio19 rafcio19 commented May 21, 2024

Resolves #7664

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.33%. Comparing base (3a1ffaa) to head (6e776bc).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7714   +/-   ##
=======================================
  Coverage   94.33%   94.33%           
=======================================
  Files        1087     1087           
  Lines       92765    92768    +3     
=======================================
+ Hits        87508    87512    +4     
+ Misses       5257     5256    -1     
Flag Coverage Δ
servertests 29.45% <0.00%> (-0.01%) ⬇️
unittests 94.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafcio19 rafcio19 marked this pull request as ready for review May 22, 2024 12:23
@bblommers bblommers added this to the 5.0.8 milestone May 24, 2024
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thank you for fixing this @rafcio19!

@bblommers bblommers merged commit 108de5f into getmoto:master May 24, 2024
40 checks passed
Copy link
Contributor

This is now part of moto >= 5.0.8.dev20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECS update_service with desiredCount does not affect runningCount
2 participants