Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure boto3's managed transfer won't use threads #829

Closed
wants to merge 3 commits into from

Conversation

snordhausen
Copy link
Contributor

fixes #816 (and potentially some other tickets related to managed transfer methods)

Stefan Nordhausen added 3 commits January 24, 2017 17:34
This adds/fixes the following things:
- Add missing KeyCount in result (fixes getmoto#734).
- Do not hard code MaxKeys to 1000.
- Truncate result if it has more than MaxKeys items. Set IsTruncated
    and NextContinuationToken accordingly.
- Support the StartAfter parameter.
- Return Owner information only when FetchOwner=True is given.
- "Prefix" in response is now "" instead of None when omitted in request.
- "Delimiter" is now omitted from response when not given in request.
@coveralls
Copy link

coveralls commented Feb 14, 2017

Coverage Status

Coverage decreased (-0.02%) to 93.411% when pulling fc5c339 on snordhausen:master into d3df810 on spulec:master.

@JackDanger
Copy link
Collaborator

@snordhausen This looks useful! Can you please rebase on the latest code since the httpretty patching has changed significantly?

@snordhausen
Copy link
Contributor Author

I'm not sure if this feature is still needed since #848 talks about deprecating HTTPretty. Can @spulec please shed some light on this?

@spulec
Copy link
Collaborator

spulec commented Jun 15, 2017

My guess is that this is no longer needed with the current system

@JackDanger
Copy link
Collaborator

I'm closing this until someone mentions they need it.

@JackDanger JackDanger closed this Jul 7, 2017
@leopepe
Copy link

leopepe commented Jul 19, 2021

It is 2021 and this issue still happening. In my setup I am using pyspark 3.1.2 and moto 2.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upload file with boto, download it with boto3: file gets corrupted (wrong md5 sum)
5 participants