fix: externalize deps (#392)

* fix: externalize deps * docs: add changeset
getnacelle · Jun 9, 2023 · 254f5b0 · 254f5b0 · vercel · Jun 9, 2023
1 parent aa293e4
commit 254f5b0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/.changeset/mighty-balloons-cry.md b/.changeset/mighty-balloons-cry.md
@@ -0,0 +1,5 @@
+---
+'@nacelle/storefront-sdk': patch
+---
+
+Fixes an internal issue with `@nacelle/storefront-sdk`'s build process, which was causing some external package code to be inadvertently bundled in the `@nacelle/storefront-sdk` package code. This issue both increased the package size and caused issues in Nuxt 2 projects.
diff --git a/packages/storefront-sdk/vite.config.ts b/packages/storefront-sdk/vite.config.ts
@@ -17,16 +17,14 @@ export const config: UserConfig = {
 		rollupOptions: {
 			external: [
 				'@urql/core',
-				'@urql/exchange-persisted-fetch',
-				'@urql/exchange-retry',
-				'graphql'
+				'@urql/exchange-persisted',
+				'@urql/exchange-retry'
 			],
 			output: {
 				globals: {
 					'@urql/core': 'Urql',
-					'@urql/exchange-persisted-fetch': 'UrqlExchangePersistedFetch',
-					'@urql/exchange-retry': 'UrqlExchangeRetry',
-					graphql: 'Graphql'
+					'@urql/exchange-persisted': 'UrqlExchangePersisted',
+					'@urql/exchange-retry': 'UrqlExchangeRetry'
 				}
 			}
 		}