fix: don't set null/undefined HTTP headers

Closes #52
getndazn · Jun 21, 2019 · 14c62ff · 14c62ff
1 parent 728c41c
commit 14c62ff
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/packages/lambda-powertools-http-client/__tests__/correlation-ids.js b/packages/lambda-powertools-http-client/__tests__/correlation-ids.js
@@ -91,6 +91,23 @@ describe('HTTP client (correlationIds)', () => {
         })
       })
     })
+
+    describe('when there are null or undefined correlation IDs', () => {
+      it('does not add them to HTTP headers', async () => {
+        CorrelationIds.replaceAllWith({
+          awsRequestId: undefined,
+          awsRegion: null,
+          'x-correlation-id': 'theburningmonk'
+        })
+
+        await verifyHeaders({}, headers => {
+          expect(headers['x-correlation-id']).toBe('theburningmonk')
+          const headerKeys = Object.keys(headers)
+          expect(headerKeys).not.toContain('awsRequestId')
+          expect(headerKeys).not.toContain('awsRegion')
+        })
+      })
+    })
   })
 
   describe('when the correlationIds option is provided', () => {

diff --git a/packages/lambda-powertools-http-client/index.js b/packages/lambda-powertools-http-client/index.js
@@ -34,7 +34,10 @@ function getRequest (uri, method) {
 function setHeaders (request, headers) {
   const headerNames = Object.keys(headers)
   headerNames.forEach(h => {
-    request = request.set(h, headers[h])
+    const headerValue = headers[h]
+    if (headerValue) {
+      request = request.set(h, headerValue)
+    }
   })
 
   return request