build(deps): install all deps #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
When running
lerna bootstrapall dependencies should be installed in packages. However, due to a bug listed: lerna/lerna#1457, this doesn't currently happen. Due to this, package-lock files for all packages are not fully representative of all deps and dev deps.As a workaround, update from using
lerna bootstrapto performing the commands as 2 commands manually.This will allow package-lock files to be in sync as well as allowing dependabot automated updates to not fail.
All package-lock files have also been updated as a result.
How did you implement it:
Update the
installnpm script to runlerna exec npm ci && lerna linkHow can we verify it:
Run
npm iand ensure all packages have dependencies install and symlinked with package-lock files also updated with all dependencies.Is this ready for review?: YES
Is it a breaking change?: NO