Fix #3493 — ensure SVG logos are visible with SHOW_BLOG_TITLE = False

getnikola · Jan 2, 2021 · b44b34e · b44b34e
1 parent 578e535
commit b44b34e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/nikola/conf.py.in b/nikola/conf.py.in
@@ -288,6 +288,8 @@ COMPILERS = ${COMPILERS}
 
 # If you want to hide the title of your website (for example, if your logo
 # already contains the text), set this to False.
+# Note: if your logo is a SVG image, and you set SHOW_BLOG_TITLE = False,
+# you should explicitly set a height for #logo in CSS.
 # SHOW_BLOG_TITLE = True
 
 # Paths for different autogenerated bits. These are combined with the

diff --git a/nikola/data/themes/base/assets/css/theme.css b/nikola/data/themes/base/assets/css/theme.css
@@ -312,6 +312,11 @@ pre.code, code {
 	overflow: auto;
 }
 
+/* Set a minimum logo height to ensure .svg are displayed if there is no brand text (#3493) */
+#logo {
+	min-height: 25px;
+}
+
 /* SOURCE: https://github.com/h5bp/html5-boilerplate/blob/master/src/css/main.css */
 @media print {
 	*,

diff --git a/nikola/data/themes/bootstrap4/assets/css/theme.css b/nikola/data/themes/bootstrap4/assets/css/theme.css
@@ -230,3 +230,8 @@ pre.code {
 html[dir="rtl"] body {
     text-align: right;
 }
+
+/* Set a minimum logo height to ensure .svg are displayed if there is no brand text (#3493) */
+#logo {
+    min-height: 25px;
+}